Add installation and packaging targets #28
+56
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er entrypoint with rsync.
…ld and CPack packaging.
uekerman
requested changes
Jan 4, 2026
Member
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Your cmake/CPackConfig.cmake is missing. Could you please still add it?
Comment on lines
+32
to
+56
| RUN echo '#!/bin/bash' > /entrypoint.sh && \ | ||
| echo 'set -e' >> /entrypoint.sh && \ | ||
| echo 'SOURCE_DIR="/mnt/cpack-exercise"' >> /entrypoint.sh && \ | ||
| echo 'BUILD_DIR="/tmp/build"' >> /entrypoint.sh && \ | ||
| echo 'if [ ! -d "$SOURCE_DIR" ]; then' >> /entrypoint.sh && \ | ||
| echo ' echo "Error: Source directory $SOURCE_DIR not found. Did you mount the volume?"' >> /entrypoint.sh && \ | ||
| echo ' exit 1' >> /entrypoint.sh && \ | ||
| echo 'fi' >> /entrypoint.sh && \ | ||
| echo 'echo "Setting up build environment..."' >> /entrypoint.sh && \ | ||
| echo 'mkdir -p "$BUILD_DIR"' >> /entrypoint.sh && \ | ||
| echo 'rsync -av --exclude "build" "$SOURCE_DIR/" "$BUILD_DIR/"' >> /entrypoint.sh && \ | ||
| echo 'cd "$BUILD_DIR"' >> /entrypoint.sh && \ | ||
| echo 'echo "Configuring project..."' >> /entrypoint.sh && \ | ||
| echo 'cmake -B build -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON .' >> /entrypoint.sh && \ | ||
| echo 'echo "Building project..."' >> /entrypoint.sh && \ | ||
| echo 'cmake --build build' >> /entrypoint.sh && \ | ||
| echo 'echo "Creating packages..."' >> /entrypoint.sh && \ | ||
| echo 'cd build' >> /entrypoint.sh && \ | ||
| echo 'cpack -G TGZ' >> /entrypoint.sh && \ | ||
| echo 'cpack -G DEB' >> /entrypoint.sh && \ | ||
| echo 'echo "Copying packages to host..."' >> /entrypoint.sh && \ | ||
| echo 'cp *.tar.gz "$SOURCE_DIR/"' >> /entrypoint.sh && \ | ||
| echo 'cp *.deb "$SOURCE_DIR/"' >> /entrypoint.sh && \ | ||
| echo 'echo "Done! Packages are available in $SOURCE_DIR"' >> /entrypoint.sh && \ | ||
| chmod +x /entrypoint.sh |
Member
There was a problem hiding this comment.
Better add the script here explicitly and copy it to the container. Not easy to maintain like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLab: nagasaji
I completed the optional and bonus tasks.
How to Install:
lintian output: