WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert) by jtp10181 · Pull Request #2681 · SmartThingsCommunity/SmartThingsEdgeDrivers

jtp10181 · 2026-01-02T04:17:13Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding Zooz ZSE50 for WWST Certification

Summary of Completed Tests

Tested all features manually
Passed full integration test from the developer test suite

greens · 2026-01-13T23:34:26Z

drivers/SmartThings/zwave-siren/profiles/zooz-zse50.yml

+        version: 1
+      - id: battery
+        version: 1
+      - id: firmwareUpdate


We don't typically include this capability for Z-Wave devices, since we don't do Z-Wave OTA.

This solution was actually suggested by the WWST team who was working directly with Zooz (wwst.support@samsung.com, not sure who exactly). It allows us to populate the currentVersion value and have it show in the UI. ST does not really offer any other way to expose that information. Zooz has many different firmware versions for each devices so when troubleshooting with a customer they need to know what firmware they have. The driver passed the Full Integration Test on the developer certification portal.

thank you for providing that info

greens · 2026-01-13T23:41:16Z

drivers/SmartThings/zwave-siren/src/init.lua

+    capabilities.chime,
+    capabilities.powerSource,
+    capabilities.audioVolume,
+    capabilities.firmwareUpdate,


this can be omitted, as we have no default handling for the firmwareUpdate capability for Z-Wave

greens · 2026-01-13T23:41:34Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

@@ -0,0 +1,409 @@
+-- Copyright 2022 SmartThings


greens · 2026-01-13T23:43:12Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+--- @param self st.zwave.Driver
+--- @param device st.zwave.Device
+local function update_firmwareUpdate_capability(self, device, component, major, minor)
+  if device:supports_capability_by_id(capabilities.firmwareUpdate.ID, component.id) then
+    local fmtFirmwareVersion = string.format("%d.%02d", major, minor)
+    device:emit_component_event(component, capabilities.firmwareUpdate.currentVersion({ value = fmtFirmwareVersion }))
+  end
+end
+
+--- Update the built in capability firmwareUpdate's currentVersion attribute with the
+--- Zwave version information received during pairing of the device.
+--- @param self st.zwave.Driver
+--- @param device st.zwave.Device
+local function updateFirmwareVersion(self, device)
+  local fw_major = (((device.st_store or {}).zwave_version or {}).firmware or {}).major
+  local fw_minor = (((device.st_store or {}).zwave_version or {}).firmware or {}).minor
+  if fw_major and fw_minor then
+    update_firmwareUpdate_capability(self, device, device.profile.components.main, fw_major, fw_minor)
+  else
+    device.log.warn("Firmware major or minor version not available.")
+  end
+end


unless you're using this somewhere, these can be omitted

Both are being used, in the same file. Zooz wants to populate the firmware version where users can see it.

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

Line 287 in 3b569c8

update_firmwareUpdate_capability(driver, device, device.profile.components.main, major, minor)

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

Line 305 in 3b569c8

updateFirmwareVersion(driver, device)

greens · 2026-01-13T23:55:48Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+--- @param device st.zwave.Device
+local function device_init(driver, device)
+  device:send(Version:Get({}))
+  device:try_update_metadata({ profile = ZSE50_DEFAULT_PROFILE })


the profile shouldn't be changing so you shouldn't need to reset it

greens · 2026-01-13T23:56:42Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+  device:try_update_metadata({ profile = ZSE50_DEFAULT_PROFILE })
+
+  if (device:get_field("TONES_DURATION") == nil or device:get_field("TONE_DEFAULT") == nil) then
+    rebuildTones(device)


How often are these values likely to change?

They do get stored as persistent after being rebuilt. This particular check just makes sure it is not nil for any reason, especially when switching from one driver to another. I could possibly move the check to added instead if you think that would be better but I have pretty extensively tested it already how it is written.

Also, it could need to be rebuilt at any time, the user can plug the device into a PC and add or remove tones. There is an option in the modes menu to force a rebuild.

I assumed something like that was possible. Thanks for confirming.

greens · 2026-01-14T00:05:08Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+  tones_list[tone_id] = string.format("%s: %s (%ss)", tone_id, tone_name, duration)
+  tones_duration[tone_id] = duration
+  device:set_field("TONES_LIST_TMP", tones_list)
+  device:set_field("TONES_DURATION_TMP", tones_duration)


it seems a little redundant to use two maps here where the only unique information one of them includes is the tone_name. Could you just use one map like:

{ [tone_id] = {duration: X, name: Y} }

And construct the strings in the places you actually want to emit them?

Also, the value of capabilities.mode.supportedArguments will be identical to device:get_field("TONES_LIST") most of the time, so it seems especially redundant there.

greens

Please write and include some unit tests and remove your debug logging.

jtp10181 · 2026-01-14T16:33:19Z

I will work on the remaining issues and follow up when complete.

pegor-karoglanian · 2026-02-05T16:58:55Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+      duration = duration * device.preferences.playbackLoop
+    end
+  end
+  log.debug(string.format("Playing Tone: %s, playbackMode %s, duration %ss", tone_id, playbackMode, duration))


Please remove debug log once you are ok with functionality.

pegor-karoglanian · 2026-02-05T16:59:12Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+  local soundSwitch_refresh = function()
+    local chime = device:get_latest_state("main", capabilities.chime.ID, capabilities.chime.chime.NAME)
+    local mode = device:get_latest_state("main", capabilities.mode.ID, capabilities.mode.mode.NAME)
+    log.debug(string.format("soundSwitch_refresh: %s | %s", chime, mode))


Same as above

pegor-karoglanian · 2026-02-05T16:59:46Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+  local tones_duration = device:get_field("TONES_DURATION_TMP") or {}
+  log.debug(string.format("***DEBUG*** tone_info_report_handler... %s:%s (%ss)", tone_id, tone_name, duration))
+
+  --table.insert(tones_list, string.format("%s: %s (%ss)", tone_id, tone_name, duration))


Please remove commented out code

pegor-karoglanian · 2026-02-05T17:00:04Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+
+    local tones_arguments = { "Off" }
+    for il, vl in ipairs(tones_list) do
+      --log.debug(string.format("#%s:: '%s' // '%s'", il, tones_list[il], vl))


jtp10181 added 2 commits January 1, 2026 22:03

Add Zooz ZSE50 to zwave-siren

2f5426e

Fix fingerprint deviceLabel for ZSE50

3b569c8

greens requested review from pegor-karoglanian and wkhenon January 13, 2026 23:32

greens reviewed Jan 13, 2026

View reviewed changes

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

@@ -0,0 +1,409 @@

-- Copyright 2022 SmartThings

Copy link

Contributor

greens Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date

greens reviewed Jan 13, 2026

View reviewed changes

greens reviewed Jan 14, 2026

View reviewed changes

greens changed the title ~~Add Zooz ZSE50 to zwave-siren (for WWST Cert)~~ WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert) Jan 14, 2026

pegor-karoglanian reviewed Feb 5, 2026

View reviewed changes

Conversation

jtp10181 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtp10181 Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtp10181 Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

jtp10181 commented Jan 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jtp10181 commented Jan 2, 2026 •

edited

Loading

jtp10181 Jan 13, 2026 •

edited

Loading

greens Jan 13, 2026 •

edited

Loading

jtp10181 Jan 14, 2026 •

edited

Loading