Matter Switch: Add garage door profile and device override#2702
Open
hcarter-775 wants to merge 2 commits intomainfrom
Open
Matter Switch: Add garage door profile and device override#2702hcarter-775 wants to merge 2 commits intomainfrom
hcarter-775 wants to merge 2 commits intomainfrom
Conversation
hcarter-775
requested review from
ctowns,
gharveymn,
greens and
nickolas-deboom
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 480 suites 0s ⏱️ Results for commit e083ce1. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e083ce1 |
gharveymn
reviewed
Jan 13, 2026
drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua
Outdated
Show resolved
Hide resolved
gharveymn
reviewed
Jan 15, 2026
| end | ||
|
|
||
| if is_child_device and generic_profile == switch_utils.get_product_override_field(device, "initial_profile") then | ||
| if not switch_utils.get_product_override_field(device, "on_children_only") or is_child_device and |
Contributor
There was a problem hiding this comment.
I think you'll need parentheses around the first two conditions here. Here's what'll happen otherwise:
> if true or false and false then print "hi" end
hi
> if (true or false) and false then print "hi" end
>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Add a new garage door profile
Summary of Completed Tests