Add vid/pid of the Schlage Sense Pro to new-matter-lock#2748
Open
HunsupJung wants to merge 2 commits intomainfrom
Open
Add vid/pid of the Schlage Sense Pro to new-matter-lock#2748HunsupJung wants to merge 2 commits intomainfrom
HunsupJung wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
|
Invitation URL: |
Test Results 71 files 483 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 595f910. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 595f910 |
| {0x10E1, 0x2002}, -- VDA | ||
| {0x1421, 0x0042}, -- Kwikset Halo Select Plus | ||
| {0x1421, 0x0081}, -- Kwikset Aura Reach | ||
| {0x1236, 0xa538}, -- Kwikset Aura Reach |
Contributor
There was a problem hiding this comment.
The DCL lists 0x3800 for the Schlage Sense Pro - is this pid correct or is this a different model?
| {0x10E1, 0x2002}, -- VDA | ||
| {0x1421, 0x0042}, -- Kwikset Halo Select Plus | ||
| {0x1421, 0x0081}, -- Kwikset Aura Reach | ||
| {0x1236, 0xa538}, -- Kwikset Aura Reach |
Contributor
There was a problem hiding this comment.
Suggested change
| {0x1236, 0xa538}, -- Kwikset Aura Reach | |
| {0x1236, 0xa538}, -- Schlage Sense Pro |
Collaborator
Author
There was a problem hiding this comment.
You are right. Thank you for checking.
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
Summary of Completed Tests