Open
Conversation
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
|
Duplicate profile check: Warning - duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 483 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 6d1d895. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6d1d895 |
ldeora
reviewed
Feb 3, 2026
| local DOOR_STATE_MAP = { | ||
| [DoorStateEnum.DOOR_OPEN] = doorState.open, | ||
| [DoorStateEnum.DOOR_CLOSED] = doorState.closed, | ||
| [DoorStateEnum.DOOR_JAMMED] = doorState.jameed, |
ldeora
reviewed
Feb 3, 2026
| if clus_has_feature(DoorLock.types.Feature.DOOR_POSITION_SENSOR) then | ||
| table.insert(main_component_capabilities, capabilities.doorState.ID) | ||
| device.thread:call_with_delay(5, function(t) | ||
| device:emit_event(capabilities.doorState.supportedDoorStates({"open", "closed"}, {visibility = {displayed = false}})) -- open and closed are madatory |
Contributor
|
@HunsupJung can you look at the unit test failure and also add new unit tests for the DPS functionality? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
Summary of Completed Tests