Add support for additional Closure device types#2751
Open
nickolas-deboom wants to merge 4 commits intomigrate-window-covering-driver-to-matter-switchfrom
Open
Add support for additional Closure device types#2751nickolas-deboom wants to merge 4 commits intomigrate-window-covering-driver-to-matter-switchfrom
nickolas-deboom wants to merge 4 commits intomigrate-window-covering-driver-to-matter-switchfrom
Conversation
|
Duplicate profile check: Warning - duplicate profiles detected. |
nickolas-deboom
commented
Feb 3, 2026
| - id: refresh | ||
| version: 1 | ||
| categories: | ||
| - name: Door |
Contributor
Author
There was a problem hiding this comment.
A request for a new Gate category has been opened, and once that's published we can update the category here to reflect that
nickolas-deboom
force-pushed
the
support-additional-closure-types
branch
from
ce17223 to
4803fa1
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6128583 |
This adds support for Coverings, Gate, Doors, and GarageDoors closure subtypes.
nickolas-deboom
force-pushed
the
support-additional-closure-types
branch
from
4803fa1 to
b0c7eb5
Compare
nickolas-deboom
commented
Feb 4, 2026
| device:emit_event_for_endpoint(ib.endpoint_id, capabilities.windowShadeLevel.shadeLevel(level)) | ||
| end | ||
|
|
||
| function ClosureAttributeHandlers.main_state_attr_handler(driver, device, ib, response) |
Contributor
Author
There was a problem hiding this comment.
Looking over this logic again, some changes are definitely needed. There is no guaranteed ordering of when these attributes will be processed and so saving the data in fields in these handlers doesn't mean that the fields would contain the latest report if a given attribute is received after another one. I'm going to try a few different ways to restructure this logic and will add some unit tests to verify
nickolas-deboom
force-pushed
the
support-additional-closure-types
branch
from
16b02c7 to
2b519fa
Compare
nickolas-deboom
force-pushed
the
support-additional-closure-types
branch
from
2b519fa to
97b819c
Compare
nickolas-deboom
force-pushed
the
support-additional-closure-types
branch
from
1fa859f to
0b53893
Compare
nickolas-deboom
force-pushed
the
support-additional-closure-types
branch
from
0b53893 to
6128583
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the Covering, Gate, Door, and GarageDoor closure subtypes.
Note that this PR depends on #2714