Various fixes for handling of target paths.#933
Merged
Conversation
…of manifest files when target is a directory
jdalton
approved these changes
Nov 21, 2025
jdalton
pushed a commit
that referenced
this pull request
Nov 24, 2025
jdalton
pushed a commit
that referenced
this pull request
Nov 24, 2025
jdalton
pushed a commit
that referenced
this pull request
Nov 24, 2025
jdalton
pushed a commit
that referenced
this pull request
Nov 24, 2025
jdalton
pushed a commit
that referenced
this pull request
Nov 24, 2025
jdalton
pushed a commit
that referenced
this pull request
Nov 24, 2025
jdalton
pushed a commit
that referenced
this pull request
Nov 24, 2025
jdalton
pushed a commit
that referenced
this pull request
Nov 24, 2025
jdalton
added a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #811 and #794 to v1.
Notice, the change is #794 is technically breaking since we now include manifest files recursive when the target is a directory, i.e., we treat
socket scan create ./foo/barthe same ascd /foo/bar && socket scan create .. I don't know if this change is acceptable, but I think the old behaviour of only recursively adding manifest files for.and./was weird, and it also doesn't match what written in the help menu.