-
Notifications
You must be signed in to change notification settings - Fork 36
TASK-160237: Momentum 5.2 release documentation #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
✅ Deploy Preview for support-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| debug_throttle_max_num_same_message = 5 | ||
| ``` | ||
|
|
||
| With this configuration, only five lines of the same debug message will be logged during the time interval specified by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkoerichbird safe to assume that if the interval passes without reaching the limit, the message will still be logged? will it be deduped in that case? might be worth adding a clarifying line around this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will be logged. I'll clarify better.
…request) Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
| string _routing_domain; | ||
|
|
||
| /** @since 5.2 */ | ||
| /* TASK-115992: make sure an attempted IP can be logged in case of temp/perm failures */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) Do we want ticket numbers in a public doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it from doc; it was reproduced "as-is" from the source code.
| > __**_WARNING:_**__ Be cautious when enabling debug throttling, as it may cause some performance overhead due to the additional | ||
| > processing required to track and suppress repeated messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really non-trivial? I wouldn't expect there'd be that many unique format strings, and we save the cost of logging the msgs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug throttling is a feature that I believe is most useful when turning on debugging messages (level >= INFO), and, depending on the subsystem the customer enables, many different strings (in different formats) can be printed.
| The clamav module is an open source antivirus engine that is part of the default Momentum installation. | ||
| The clamav module allows integration with the open source ClamAV antivirus engine. | ||
|
|
||
| > **NOTE:** Since version 5.2, the `msys-clamav` package, which contained the ClamAV engine, is no longer shipped with the Momentum installation bundle. To use this clamav module, the engine must be installed using the general available ClamAV packages (e.g., `clamav` and `clamd` RPMs), then configured and maintained separately by following the official ClamAV [documentation](https://docs.clamav.net/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true for all OSs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes; msys-clamav isn't expected to be shipped anymore with Momentum 5.2 in all supported on-prem OSes: https://github.com/SparkPost/Momentum/commit/04686a61866b7df44270700885499e10b1c29371
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
No description provided.