Merged
Conversation
- prefer Nullable<T> when not-always-present
philon-msft
approved these changes
Feb 11, 2026
| /// <param name="flags">The command flags to use.</param> | ||
| /// <returns>The data captured during <c>HOTKEYS</c> profiling.</returns> | ||
| [Experimental(Experiments.Server_8_6, UrlFormat = Experiments.UrlFormat)] | ||
| HotKeysResult? HotKeysGet(CommandFlags flags = CommandFlags.None); |
Collaborator
There was a problem hiding this comment.
Must we add more synchronous methods? :(
Collaborator
Author
There was a problem hiding this comment.
It is a great question. Historically we've kept them aligned (and we have unit tests that enforce that), but maybe we should start to rethink that. I think that's a bigger discussion than this PR, though.
Maybe step one is a custom Roslyn analyzer to start nudging people in the direction of preferring the async APIs, without using [Obsolete] or [Experimental] hackery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOTKEYSis a new profiling API in 8.6, allowing a server-side profiling session that shows (unsurprisingly) the "hottest" keys observed during the profiling, separately by CPU and network (which can be enabled/disabled independently).Usage is discussed in the docs as part of this PR
Note tests are linked to 8.6; CI bumped to 8.6 GA:
On files: I'm trying a new layout here; instead of making a mess throughout huge files, I've focused these changes at the "feature" scope; the API is in HotKeys.cs, with the implementation code in sub-files:
IMO this is much more friendly, and if there's no objections, I'll add "get the AI to move things around" to the backlog.