Replace sublime_lib.RegionOption #422
Open
+21
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST4 has been shipping `sublime.RegionFlags` for quite a while. Time to switch from 3rd-party to built-in solution.
FichteFoll
reviewed
Jan 21, 2026
Member
FichteFoll
left a comment
FichteFoll
left a comment
There was a problem hiding this comment.
Thanks. I'll leave this unmerged until the next release to remind myself to adjust the release channel for the ST build requirement.
| Example: | ||
| flags: sublime.RegionFlags = region_flags_from_strings(["DRAW_EMPTY", "DRAW_NO_FILL"]) | ||
| """ | ||
| return RegionFlags(sum(getattr(RegionFlags, n, RegionFlags.NONE) for n in flag_names)) |
Member
There was a problem hiding this comment.
Suggested change
| return RegionFlags(sum(getattr(RegionFlags, n, RegionFlags.NONE) for n in flag_names)) | |
| return sum(getattr(RegionFlags, n, RegionFlags.NONE) for n in set(flag_names)) |
Isn't the outer RegionFlags call redundant since we're already getting and summing RegionFlags "instances"? Also wrapping in a set to deduplicate the strings and prevent unintended side effects.
Member
Author
There was a problem hiding this comment.
Runtime yes, typechecker/linter no. Without that pyright/basedpyright complains about any assignments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ST4 has been shipping
sublime.RegionFlagsfor quite a while.Maybe worth to switch from 3rd-party to built-in solution.
Note: requires ST4135+.