Skip to content

Conversation

@Kyujenius
Copy link
Contributor

🎯 Changes

This PR improves test coverage for mergeForm.ts from 87.09% to 100% by adding comprehensive tests for previously uncovered edge cases.

Coverage Improvement

Before:

  • Uncovered lines: 17, 19, 105-106

After:

  • All lines covered
image

Type System Note

The mergeForm tests use as any type assertion due to FormApi's 12 generic parameters where TSubmitMeta defaults to never, creating incompatibility with mergeForm's any constraint. This is a type system limitation only - runtime behavior is correct. In production usage via useTransform, this receives AnyFormApi and avoids the issue.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

This PR only adds tests without modifying any implementation code or public APIs. No changeset is required.

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026

⚠️ No Changeset found

Latest commit: 2baa8f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Feb 2, 2026

View your CI Pipeline Execution ↗ for commit 2baa8f4

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 43s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-02 14:36:22 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 2, 2026

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@2012

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@2012

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@2012

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@2012

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@2012

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@2012

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@2012

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@2012

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@2012

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@2012

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@2012

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@2012

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@2012

commit: 2baa8f4

@sentry
Copy link

sentry bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.85%. Comparing base (6892ed0) to head (2baa8f4).
⚠️ Report is 128 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2012      +/-   ##
==========================================
- Coverage   90.35%   89.85%   -0.50%     
==========================================
  Files          38       48      +10     
  Lines        1752     1952     +200     
  Branches      444      491      +47     
==========================================
+ Hits         1583     1754     +171     
- Misses        149      177      +28     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant