-
-
Notifications
You must be signed in to change notification settings - Fork 584
test(form-core): improve mergeForm coverage to 100% #2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 2baa8f4
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2012 +/- ##
==========================================
- Coverage 90.35% 89.85% -0.50%
==========================================
Files 38 48 +10
Lines 1752 1952 +200
Branches 444 491 +47
==========================================
+ Hits 1583 1754 +171
- Misses 149 177 +28
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎯 Changes
This PR improves test coverage for
mergeForm.tsfrom 87.09% to 100% by adding comprehensive tests for previously uncovered edge cases.Coverage Improvement
Before:
After:
Type System Note
The
mergeFormtests useas anytype assertion due to FormApi's 12 generic parameters whereTSubmitMetadefaults tonever, creating incompatibility with mergeForm'sanyconstraint. This is a type system limitation only - runtime behavior is correct. In production usage viauseTransform, this receivesAnyFormApiand avoids the issue.✅ Checklist
pnpm test:pr.🚀 Release Impact
This PR only adds tests without modifying any implementation code or public APIs. No changeset is required.