fix(hotkeys): add ? to supported punctuation keys#30
fix(hotkeys): add ? to supported punctuation keys#30MohammedALjaberi wants to merge 3 commits intoTanStack:mainfrom
Conversation
Adds to PunctuationKey type and PUNCTUATION_KEYS constant, enabling for help shortcuts. Fixes TanStack#19
@tanstack/hotkeys
@tanstack/hotkeys-devtools
@tanstack/preact-hotkeys
@tanstack/preact-hotkeys-devtools
@tanstack/react-hotkeys
@tanstack/react-hotkeys-devtools
@tanstack/solid-hotkeys
@tanstack/solid-hotkeys-devtools
commit: |
8ebab0e to
3632818
Compare
|
Some punctuation on some/most layouts is "Shift affected". Like on most keyboards "/" is the question key when shift is pressed. So adding just "?" would add some duplication. I'm thinking more and more about having punctuation go through some kind of event.code map to actually fix issues like this. |
08205b0 to
305ac29
Compare
@KevinVandy I’ve updated the PR to use an |
Adds to PunctuationKey type and PUNCTUATION_KEYS constant, enabling for help shortcuts.
Fixes #19
🎯 Changes
✅ Checklist
pnpm run test:pr.🚀 Release Impact