-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat(query-devtools) set data to undefined on Trigger Error in TanstackQueryDevtools #10072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query-devtools) set data to undefined on Trigger Error in TanstackQueryDevtools #10072
Conversation
🦋 Changeset detectedLatest commit: 7528079 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…n-Trigger-Error-in-TanstackQueryDevtools
📝 WalkthroughWalkthroughAdds a changeset file documenting a minor version bump for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Do these changes count as dev-only (per |
|
View your CI Pipeline Execution ↗ for commit 7528079
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10072 +/- ##
===========================================
- Coverage 36.87% 18.35% -18.52%
===========================================
Files 245 51 -194
Lines 11103 2936 -8167
Branches 2083 674 -1409
===========================================
- Hits 4094 539 -3555
+ Misses 6484 2134 -4350
+ Partials 525 263 -262
🚀 New features to boost your workflow:
|
|
🎉 This PR has been released! Thank you for your contribution! |
🎯 Changes
Make Trigger Error set data to null so that error boundaries can be more easily tested using the devtools (no longer need to manually edit the data to trigger error boundary).
More info here: #10044
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.