fix(virtual-core): add 'instant' to ScrollBehavior type#1122
Open
muraliavarma wants to merge 2 commits intoTanStack:mainfrom
Open
fix(virtual-core): add 'instant' to ScrollBehavior type#1122muraliavarma wants to merge 2 commits intoTanStack:mainfrom
muraliavarma wants to merge 2 commits intoTanStack:mainfrom
Conversation
The W3C spec and all modern browsers support 'instant' as a valid ScrollBehavior value, but the type only allowed 'auto' | 'smooth'. Closes TanStack#1074
🦋 Changeset detectedLatest commit: 2d66e31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Add
'instant'to theScrollBehaviortype invirtual-core.The W3C spec defines
ScrollBehavioras"auto" | "smooth" | "instant", and all modern browsers support it. The library's custom type only included"auto" | "smooth", causing a TypeScript error when usingbehavior: 'instant'withscrollToIndex/scrollToOffset.Closes #1074
✅ Checklist
pnpm run test:pr.🚀 Release Impact