Open
Conversation
EmmaSprings
approved these changes
Mar 2, 2022
EmmaSprings
left a comment
There was a problem hiding this comment.
First of all, very well done! Your GitHub tracker works fine when viewing it, no bugs here.
I like how you added the commits and pull requests to its own section as a status bar! Very clever.
To me, the code is easy to read and understand. I read you would like to refactor the code a bit more, And even though it works perfectly fine as is, of course that could be nice thing to practice on, and I’m sure you will get the chance in other projects, so to just think about it now is really cool!
Nice and clean styling makes it easy to follow your process too.
You’ve definitely reached the blue level requirements and you should be really happy with your project!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to my deployed project:
https://flamboyant-jackson-27aaa3.netlify.app/
My reflections on how this week's project turned out:
The work with API went well, however it was harder to keep the code clean/concise, thus this is a working point that can be improved. Even though I am happy with it displaying all information required I would like to refactor the code more, since I know it's possible.
Things I'd like to have clarified or explained in more detail:
Nothing I would like to have explained, rather things I would like to practice more which I know are of importance, such as promises and async/await (which is currently not used in this particular project) and passing values through functions without it losing its context (closures, scopes and binding I believe).