Conversation
…bview into jmanrique/ANDROID-17069-update-agp # Conflicts: # app/build.gradle # build.gradle # gradle.properties # gradle/wrapper/gradle-wrapper.properties # nestedscrollwebview/build.gradle
gradle.properties
Outdated
| # resources declared in the library itself and none from the library's dependencies, | ||
| # thereby reducing the size of the R class for that library | ||
| android.nonTransitiveRClass=true | ||
| android.defaults.buildfeatures.buildconfig=true |
There was a problem hiding this comment.
Part of the AGP update to 8.13.1
There was a problem hiding this comment.
Is this documented? can't find it here: https://developer.android.com/build/releases/gradle-plugin
There was a problem hiding this comment.
AGP 8.0 and higher changed several default configurations. Specifically, the BuildConfig.java file stopped being generated automatically unless you explicitly request it.
The update assistant detected that the project probably used it.
HOWEVER, we were not using BuildConfig, so we can get rid of it jejejejeje
jmanriquehiberus
requested review from
a team,
hjorrod and
pmartinbTEF
and removed request for
a team
| versionCode = "1" | ||
| versionName = "1.0" | ||
| agp = "8.13.1" | ||
| kotlin = "1.8.0" |
There was a problem hiding this comment.
Should it be updated too?
There was a problem hiding this comment.
I think it is not necessary at the moment.
org.jetbrains.kotlin.android
was recently updated to version 2.1.20, but
androidx.core:core-ktx
and
com.google.android.material:material
were not. In this case, it is not necessary to update those for the AGP update.
pmartinbTEF
left a comment
pmartinbTEF
left a comment
There was a problem hiding this comment.
Nice! Just one question
3 participants
🎟️ Jira ticket
ANDROID-17069
🥅 What's the goal?
We need to update the android gradle plugin version to
8.13.1.🚧 How do we do it?
Replace in app's
build.gradle:with
Out of scope
Given that I had to set the AGP version, previously
8.11.2 in several places, I decided to extract it to variables, creating alibs.versions.tomlfile. It did not took to much effort to do the same with the few libraries implemented in this repo, so I extracted them too tolibs.versions.toml`.