Fix: Correct HashMap size tracking and refactor LinkedList methods#7137
Closed
Born-as-Harsha wants to merge 1 commit intoTheAlgorithms:masterfrom
Closed
Fix: Correct HashMap size tracking and refactor LinkedList methods#7137Born-as-Harsha wants to merge 1 commit intoTheAlgorithms:masterfrom
Born-as-Harsha wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
Added currentSize to track the number of key-value pairs. Updated insert and delete methods to modify currentSize based on key existence. Improved encapsulation by changing LinkedList methods to return values directly and added comments for clarity.
Born-as-Harsha
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7137 +/- ##
=========================================
Coverage 78.51% 78.52%
+ Complexity 6752 6751 -1
=========================================
Files 759 759
Lines 22402 22409 +7
Branches 4400 4400
=========================================
+ Hits 17589 17596 +7
Misses 4108 4108
Partials 705 705 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{O}(1)$ Size Tracking and Encapsulation RefinementThis PR implements a critical fix for size tracking and refactors internal methods for improved efficiency and compliance with Java encapsulation principles in the HashMap data structure.🐛 Problem SolvedThe original HashMap.size() method was incorrect, as it returned the count of non-empty buckets (the array indices) instead of the total number of key-value entries stored across all linked lists. This resulted in the size being misreported whenever hash collisions occurred.