Correct Javadoc return description for cylinder surface area#7140
Closed
vardhan30016 wants to merge 1 commit intoTheAlgorithms:masterfrom
Closed
Correct Javadoc return description for cylinder surface area#7140vardhan30016 wants to merge 1 commit intoTheAlgorithms:masterfrom
vardhan30016 wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
Fix Javadoc comment for surfaceAreaCylinder method.
vardhan30016
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7140 +/- ##
=========================================
Coverage 78.51% 78.51%
Complexity 6752 6752
=========================================
Files 759 759
Lines 22402 22402
Branches 4400 4400
=========================================
Hits 17589 17589
Misses 4108 4108
Partials 705 705 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically closed because its workflows or checks failed and it has been inactive for more than 14 days. Please fix the workflows and reopen if you'd like to continue. Merging from main/master alone does not count as activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed incorrect Javadoc return description for the
surfaceAreaCylindermethod.Changes
@return volume of given cylinderto@return surface area of given cylinderThe method calculates surface area, not volume, so the javadoc was misleading.