Add Josephus Problem in C++ (Fixes #3332)

[apurvavats]

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

• I fixed Add Josephus Problem in C++ #3332
• I did not include any extra folders/libraries
• I named the pull request using Add { Josephus Problem} in {C++} format

[github-actions]

Hey @apurvavats! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:

• Subscribe to the monthly newsletter
• Become a patron
• Join us on Discord
• And, check out the rest of the list which includes links to The Renegade Coder YouTube channel and Twitter account

Thanks for your help!

[rzuckerm]

Please take a look at the project description for the appropriate usage message.

[apurvavats]

I did the required changes, please review it

[rzuckerm]

What you had before was a lot closer than what you have now. All that needed to be done was to fix the usage message. Also, I'd recommend assigning the usage message to a variable so that you don't have to keep repeating that string.

[apurvavats]

updated the message, please review again.

[apurvavats]

After checking the same program in different languages what i concluded is the solution requires only the final output and not not the output after every iteration, so please confirm once what are the requirements.

[rzuckerm]

After checking the same program in different languages what i concluded is the solution requires only the final output and not not the output after every iteration, so please confirm once what are the requirements.

The output is just supposed to be the number of the person remaining.

[rzuckerm]

@apurvavats Thanks for your contribution! After looking at the Description section of this, I can see how that would be confusing. However, the Requirements and Testing section clarify what the expected output is. I'll take this up with the founder of this repo and see what he says.

[apurvavats]

@rzuckerm can you please add the label hactoberfest accepted

[rzuckerm]

@rzuckerm can you please add the label hactoberfest accepted

The whole repo is marked with the "hacktoberfest" label, so it should count.

[apurvavats]

Thank you so much

[rzuckerm]

@apurvavats The Josephus Problem description has been updated.

[apurvavats]

@rzuckerm it still does not appear in my hactoberfest profile.

[rzuckerm]

@apurvavats Sorry, I don't know what to tell you. According to the Hacktobestfest rules:

[participating] Your PR/MRs must be in a repo tagged with the “hacktoberfest” topic, or have the “hacktoberfest-accepted” label.

Our repo is tagged with the hacktoberfest label, so this should apply. I submitted several PRs to this repo that got approved, and all mine eventually showed up in my profile.