Skip to content

update source build tools#116

Open
cathysarisky wants to merge 1 commit intoTryGhost:mainfrom
cathysarisky:new-build-tools
Open

update source build tools#116
cathysarisky wants to merge 1 commit intoTryGhost:mainfrom
cathysarisky:new-build-tools

Conversation

@cathysarisky
Copy link
Member

Prototype build tools (eventually to be added to other themes) that will retrieve shared translation strings and build them into the the theme with gulp.

@cursor
Copy link

cursor bot commented Feb 5, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 3.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Walkthrough

The pull request introduces a locale file merging feature to the build pipeline. New path constants are defined in gulpfile.js to manage shared locale sources, local override sources, and output directories. A locale merging function reads JSON files from both sources, merges them with local values taking precedence over non-blank shared values, sorts keys alphabetically, and writes merged results to the output directory. A new locales gulp task is created with file watching for locale JSON changes, and the build pipeline is updated to execute this task alongside existing CSS and JavaScript tasks. The package.json is updated to include a new devDependency for shared theme assets.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'update source build tools' is vague and generic, using non-descriptive terms that don't convey meaningful information about the specific changes (locale merging, shared assets integration, or translation string handling). Consider a more specific title such as 'Add locale merging build task for shared translation strings' to clearly describe the primary change.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately relates to the changeset by explaining the purpose of adding build tools for retrieving shared translation strings and building them into the theme with gulp.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cathysarisky cathysarisky requested a review from 9larsons February 5, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant