Remove weird pagination that read all posts regardless of the collections filter#72
Open
davidfraser wants to merge 1 commit intoTryGhost:mainfrom
Open
Remove weird pagination that read all posts regardless of the collections filter#72davidfraser wants to merge 1 commit intoTryGhost:mainfrom
davidfraser wants to merge 1 commit intoTryGhost:mainfrom
Conversation
…ions filter (cherry picked from commit 6d31b39)
Author
|
I see that this is actually reported as #33 |
Author
|
@minimaluminium I saw you said in #33 (comment) that there was a special trick needed to make get queries work with advanced layout options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I have a fairly standard collection that uses the index feed, it shows items on the second page as you scroll down that don't match it's filter. For example with the following
routes.yaml:Then items that don't have their primary tag as
blogstill appear. This seems to be fairly directly caused by this unfiltered#geton page 2 in the source code, which I don't see any reason for... (obviously I may be missing something, please say!)