More ANTLR Utils and refactoring #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoids en-us acronym and clarifies intent better fitting with other names.
General refactoring of code to unify and eliminate redundancy of abstractions. There was a LOT of duplication of abstraction between command line and runtime that is now moved to the Extensions library.
* Argument validation now moved to runtime independent "Requires" static class.
- This contains the implementation which depending on targeted framework may be polyFilled.
- This keeps intent clearer AND supports multi-targetting without pre-processor conditionals on all targets or compilations that support C#14 'extension' keyword.
* Added SourceLocation to contain both the URI of the source text AND the range for the location.
* Added more ANTLR common support
* Removed shared source library
- All of that functionality is now in Ubiquity.NET.Extensions
>[!IMPORTANT]
> The existing tests were updated to the refactoring and all
> pass. The new functionality does NOT have testing yet.
… logic and provide clarity of intent. * new semantics allow use as a drop-in replacement for `ObjectDisposedException.ThrowIf`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more ANTLR utilities and refactored to eliminate redundancies at the conceptual and implementation levels.
Moved types out of command line into general core and runtime.
General refactoring of code to unify and eliminate redundancy of abstractions. There was a LOT of duplication of abstraction between command line and runtime that is now moved to the Extensions library.
Important
The existing tests were updated to the refactoring and all
pass. The new functionality does NOT have testing yet.