Skip to content

Conversation

@andreitava-uip
Copy link
Contributor

@andreitava-uip andreitava-uip commented Jan 5, 2026

Context:

  • Agent Builder agents have no restrictions to input / output argument names (other than the recently added reserved "messages"
  • Due to how LangGraph state works, input and output args could conflict with internal state fields (ie: job attachments)"
  • After lengthy debates, this has been the best solution left.
  • Integrating the Guardrails state will come later.

@andreitava-uip andreitava-uip force-pushed the feat/isolate-inner-state branch 3 times, most recently from f1088b3 to 57a9b60 Compare January 5, 2026 14:35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this type of loop cross cutting functionality we should maybe extract in a /common package at the same level as /react as to be reused and not duplicated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true but for now i'd rather not prematurely extract packages when the hierarchy itself is not clearly defined. It should be easily done at a later date. If the plan is for us to reuse it within different loops of ours, we should think about where it should stay. If we want it to be usable by users directly (although in my opinion it is currently implemented with our state management in mind), it's a different story.

@andreitava-uip andreitava-uip force-pushed the feat/isolate-inner-state branch from 57a9b60 to 86e8867 Compare January 5, 2026 14:49
@andreitava-uip andreitava-uip merged commit 9f5788e into main Jan 5, 2026
39 checks passed
@andreitava-uip andreitava-uip deleted the feat/isolate-inner-state branch January 5, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants