Draft
Conversation
UMTensor will be TA::Tensor type with a UM allocator To avoid confusion, renames some existing uses of UMTensor
Implemented everything except serialization support (needs testing)
Right now, its just a copy of the btas type test case
This forces to use the ctor with nbatches. Only nbatch == 1 is supported anyway.
Don't include tensor.h in um_tensor.h
…ids ambiguous definitions
Follows the same logic in device/btas.h
…rsion of to_device, since pre-fetching is not a mutating operation.
Mirrors the BTAS logic for now for testing, needs to be cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements device support
TA::TensorThis PR implements device support for
TA::Tensor. A new device tile typeTA::UMTensoris introduced, and the existing device tile type based onbtas::Tensorwill be removed.Changelist
TA::UMTensor, akaTA::Tensorwith UM allocatorsbtas::Tensorbased device codeNotes
[will be added later]