Add fallback return false for passthrough methods#32
Open
SamuelGuizani wants to merge 1 commit intoViveSoftware:masterfrom
Open
Add fallback return false for passthrough methods#32SamuelGuizani wants to merge 1 commit intoViveSoftware:masterfrom
SamuelGuizani wants to merge 1 commit intoViveSoftware:masterfrom
Conversation
This patch adds a missing fallback return false; to the passthrough methods. A function must always guarantee a return value that matches its signature, even when the code path seems obvious. Without that, the compiler complains. This change ensures the method now consistently returns a valid boolean in all cases. (A small reminder that one of the most fundamental rules in programming is: if a function says it returns something… it should actually return something 😉)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a missing fallback return false; to the passthrough methods. A function must always guarantee a return value that matches its signature, even when the code path seems obvious. Without that, the compiler complains.
This change ensures the method now consistently returns a valid boolean in all cases. (A small reminder that one of the most fundamental rules in programming is: if a function says it returns something… it should actually return something 😉)