Conversation
Member
|
Where do we require 3.10? I see that in a few specific scripts, but not in the main |
Member
Author
|
Member
Author
|
The requirement for 3.10 looks like it was added in #8125 |
Member
|
Makes sense, yeah, I just think we should document it outside of those 2 side scripts, in a prominent place, so it's clear it is a requirement of the entire project. |
Member
Author
|
It also in our .ruff.toml file: `target-version = "py310" |
Member
Author
|
Done |
kripken
approved these changes
Feb 18, 2026
Builtin dicts are guaranteed ordered as of 3.7 and we require 3.10 these days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builtin dicts are guaranteed ordered as of 3.7 and we require 3.10 these days.
Also, document the 3.10 requirement in the README file and make the runtime
checks consistent.