Conversation
Normally this option default to false, and it seems like binaryen doesn't have a good reason to differ. However, this setting (originally called `--abort-on-first-failure`) has always been enabled by default since its was first added back in #771. Also name the option `--failfast` to match the name it has in the python unittest framework.
Member
Author
|
What do folks think? Does binaryen have a reason to always prefer to fail fast? |
Member
Author
|
Normally I guess this setting is not the default so that a given run can show all failures, not just the first one (I guess maybe on CI this is normally desirable..?) |
Member
|
Normally yes, though one issue we have here is that our test suite logging is very verbose. It is easy to get a failure and need to scroll back a lot to find it. I think fail-fast helps reduce this problem? Ideally we would fix the problem directly, of course... |
Member
Author
|
Ok, lets leave for now. We can revisit if things improve on the verbosity side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally this option default to false, and it seems like binaryen doesn't have a good reason to differ.
However, this setting (originally called
--abort-on-first-failure) has always been enabled by default since its was first added back in #771.Also name the option
--failfastto match the name it has in the python unittest framework.