Require --enable-shared-everything with WaitQueues#8342
Open
stevenfontanella wants to merge 2 commits intomainfrom
Open
Require --enable-shared-everything with WaitQueues#8342stevenfontanella wants to merge 2 commits intomainfrom
stevenfontanella wants to merge 2 commits intomainfrom
Conversation
stevenfontanella
force-pushed
the
waitqueue-validation
branch
from
2380848 to
aaee2c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateExactReferences(the existing body ofvalidateTypes)validateWaitQueuewhich requires--enable-shared-everythingif a struct contains a WaitQueue fieldstaticfor free functions: https://stackoverflow.com/questions/4977252/why-an-unnamed-namespace-is-a-superior-alternative-to-staticPart of #8315.