Skip to content

More filterable way to remove title attributes from author link functions#11042

Open
sabernhardt wants to merge 10 commits intoWordPress:trunkfrom
sabernhardt:title-attr-author-links-4
Open

More filterable way to remove title attributes from author link functions#11042
sabernhardt wants to merge 10 commits intoWordPress:trunkfrom
sabernhardt:title-attr-author-links-4

Conversation

@sabernhardt
Copy link

Extends option 2, with new parameters for the_author_posts_link filter:

  • Removes 'Posts by %s' title attributes from get_the_author_posts_link(), the_author_posts_link() and wp_list_authors().
  • Retains Core's 'Posts by %s' string for potential use in the the_author_posts_link hook.
  • Creates a new $use_title_attr parameter for website links in get_the_author_link() and the_author_link().

By default, this would keep a distinction between links from get_the_author_link() functions and the post archive links, if they are on the same page.

Trac 62835

Use of AI Tools: none


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt, joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sabernhardt
Copy link
Author

I was able to replace the author display name with the 'Posts by author' text in the author posts link function. I activated the Hemingway theme to find the output on single posts.

function wptrac_author_posts_link( $link, $author = '', $title = '' ) {
	if ( '' !== $title && '' !== $author ) {
		$link = str_replace(
			'>' . $author . '</a>',
			'>' . esc_html( $title ) . '</a>', 
			$link
		);
	}

	return $link;
}
add_filter( 'the_author_posts_link', 'wptrac_author_posts_link', 10, 3 );

I did not add a comparable change in the author list function because that would be verbose.

Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, minus one tiny change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants