Skip to content

Darken colors for action separators & metabox handles#11058

Open
joedolson wants to merge 1 commit intoWordPress:trunkfrom
joedolson:resolve-color-contrast-flags
Open

Darken colors for action separators & metabox handles#11058
joedolson wants to merge 1 commit intoWordPress:trunkfrom
joedolson:resolve-color-contrast-flags

Conversation

@joedolson
Copy link
Contributor

While these colors don't technically violate WCAG, because the contexts they are in don't contain text, they do raise chronic errors in automated testing. The darker colors are more consistent with the new admin scheme, and resolve errors, making testing easier.

Trac ticket: https://core.trac.wordpress.org/ticket/64313

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

While these colors don't technically violate WCAG, because the contexts they are in don't contain text, they do raise chronic errors in automated testing. The darker colors are more consistent with the new admin scheme, and resolve errors, making testing easier.
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant