Skip to content

Conversation

@dmsnell
Copy link
Member

@dmsnell dmsnell commented Feb 29, 2024

Trac ticket: Core-60455

Alternative to #6054

When reaching text nodes that require creating elements during active format reconstruction, aborts the HTML Processor.

This prevents progressing into a document where the text nodes would change the structure and affect breadcrumbs. Until the HTML Processor properly supports text nodes this makes it possible to continue operating safely.

@dmsnell dmsnell changed the title Html api/abort on text nodes requiring reconstruction HTML API: Abort on text nodes requiring reconstruction Feb 29, 2024
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dmsnell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dmsnell
Copy link
Member Author

dmsnell commented Mar 5, 2024

Closing this because I don't think that the approach is sound. Favoring the more comprehensive approach of tracking every token in the HTML Processor, in #6054

@dmsnell dmsnell closed this Mar 5, 2024
@dmsnell dmsnell deleted the html-api/abort-on-text-nodes-requiring-reconstruction branch March 5, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant