Skip to content

HTML API: Expect closer on foriegn content void lookalike elements #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sirreal wants to merge 6 commits into from
Closed

HTML API: Expect closer on foriegn content void lookalike elements #7752

sirreal wants to merge 6 commits into from

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Nov 8, 2024 •
edited by ockham
Loading

Ensure that expects_closer returns false on tags that look like void HTML tags, but are actually not void tags in foreign content.

Some tags that look like void elements can be added in other namespaces. <input> is a good example.

expects_closer is intended to indicate whether a given should be closed by another tag or if it's self-closing in some way (void, "atomic," etc.).

This input tag is a void tag, expects_closer correctly returns true on the input token:

<body><input>
This input tag is not a void tag. It's a tag in the svg namespace, expects_closer should return false on the input token, but it returns true:

<svg><input>

Trac ticket: https://core.trac.wordpress.org/ticket/62363

Noticed on #7348.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Nov 8, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal sirreal marked this pull request as ready for review November 8, 2024 18:17
@github-actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, bernhard-reiter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

sirreal
sirreal commented Nov 12, 2024
View reviewed changes
ockham
ockham reviewed Nov 12, 2024
View reviewed changes
ockham
ockham approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll commit this.

@ockham
Copy link
Contributor

ockham commented Nov 12, 2024

Committed to Core trunk in https://core.trac.wordpress.org/changeset/59392.

@ockham ockham closed this Nov 12, 2024
@sirreal sirreal deleted the html-api/fix-expects-closer-foreign-voidlike branch November 12, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ockham ockham ockham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sirreal @ockham