start basic h7 support#852
Draft
RecursiveError wants to merge 6 commits intoZigEmbeddedGroup:mainfrom
Draft
Conversation
- add GPIO N-K in common/gpio_v2 - move put,toggle and read func to from common/pins_v2 common/gpio_v2
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Lint Results
Found 9 issues on changed lines in 1 file:
- port/stmicro/stm32/src/hals/STM32H723/rcc.zig: 9 issues
ℹ️ Additional issues on unchanged lines
The following 20 issue(s) exist but are not on lines changed in this PR:
drivers/framework.zig:30: Suggestion: Rename `Keyboard_Matrix` to `KeyboardMatrix`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:31: Suggestion: Rename `Debounced_Button` to `DebouncedButton`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:32: Suggestion: Rename `Rotary_Encoder` to `RotaryEncoder`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:64: Suggestion: Rename `IO_expander` to `IO_Expander`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:76: Suggestion: Rename `Cyw43_Spi` to `CYW43_SPI`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:77: Suggestion: Rename `Cyw43_Bus` to `CYW43_Bus`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:78: Suggestion: Rename `Cyw43_Runner` to `CYW43_Runner`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:210: Suggestion: Rename `Datagram_Device` to `DatagramDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:211: Suggestion: Rename `Stream_Device` to `StreamDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:213: Suggestion: Rename `Clock_Device` to `ClockDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:214: Suggestion: Rename `Block_Memory` to `BlockMemory`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/generate.zig:272: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/pins_v2.zig:47: Suggestion: Rename `InputGPIO` to `Input_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/pins_v2.zig:54: Suggestion: Rename `OutputGPIO` to `Output_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/wch/ch32v/build.zig:3: Suggestion: Rename `CpuName` to `CPU_Name`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/wch/ch32v/build.zig:10: Suggestion: Rename `KiB` to `Ki_B`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/wch/ch32v/src/hals/clocks.zig:14: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:158: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:181: TODO style comments need to have a linked microzig issue on the same line.
github-actions
bot
dismissed
their stale review
Updating with new lint results
- change sub_peripheral_enum limit from 10 to 15 - fix rcc naming
Lint ResultsFound 1 issue on changed lines in 1 file:
|
| return @intFromFloat(rcc.current_clocks.CortexSysOutput); | ||
| } | ||
|
|
||
| pub var Reset_Reason: rcc.ResetReason = .unknown; |
There was a problem hiding this comment.
Suggestion: Rename Reset_Reason to ResetReason, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.