core.Mmio: Respect field access type#895
Draft
piotrfila wants to merge 13 commits intoZigEmbeddedGroup:mainfrom
Draft
core.Mmio: Respect field access type#895piotrfila wants to merge 13 commits intoZigEmbeddedGroup:mainfrom
piotrfila wants to merge 13 commits intoZigEmbeddedGroup:mainfrom
Conversation
Lint ResultsFound 1 issue on changed lines in 1 file:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const size = @bitSizeOf(PackedT); | ||
| if ((size % 8) != 0) | ||
| @compileError("size must be divisible by 8!"); | ||
| const IntT, const reg_fields = switch (@typeInfo(PackedT)) { |
There was a problem hiding this comment.
Suggestion: Rename IntT to Int_T, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
tact1m4n3
reviewed
Feb 2, 2026
port/nordic/nrf5x/src/hal/clocks.zig
Outdated
| }, | ||
| .nrf52 => { | ||
| CLOCK.TASKS_CAL.write_raw(1); | ||
| CLOCK.TASKS_CAL.raw(1); |
Contributor
Author
There was a problem hiding this comment.
Thanks, I'm sure I've missed more. It's still early WIP I just wanted to get CI coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt at making Mmio access-type aware. This could catch things like trying to write to a read-only register.