-
Notifications
You must be signed in to change notification settings - Fork 109
feat!: update a2a.proto 0572953 #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aef135b to
48d5744
Compare
ehsavoie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jmesnil/a2a-java/blob/48d574464052bd990650d4e445751e695203a16d/spec/src/main/java/io/a2a/spec/ListTaskPushNotificationConfigParams.java hasn't been updated to have the pageSize and token
87e1038 to
78a5656
Compare
There is no change regarding them in the updated a2a.proto. What would be missing? |
78a5656 to
3756747
Compare
|
@jmesnil sorry, I read the code too quickly. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the a2a.proto definition and regenerates the spec-grpc module, leading to several API and internal changes across the client and server implementations. Key updates include renaming the msg field to message in various message types, changing lastUpdatedAfter to statusTimestampAfter in task listing parameters, and modifying the agent card's protocol version field from a single string to a list of strings (protocolVersions). Additionally, OAuth flows have been updated to remove implicit and password flows in favor of a new deviceCode flow, and a pkce_required field has been added to the AuthorizationCodeOAuthFlow. The extended agent card retrieval mechanism has also been refactored to align with these protocol changes. A minor redundancy was found in the JsonMessages.java test file where extendedAgentCard was listed twice in the capabilities object.
client/transport/jsonrpc/src/test/java/io/a2a/client/transport/jsonrpc/JsonMessages.java
Outdated
Show resolved
Hide resolved
based on commit a2aproject/A2A@0572953 spec-grpc module has been regenerated from the updated a2a.proto Key changes: * Agent card * extendedAgentCard is not specified by capabilities (instead of `supportsExtendedAgentCard` field) * protocolVersions is a list (instead of a single `protocolVersion`) * SendMessage * `msg` field is now named `message` * ListTask * timestamp is now named statusTimestampAfter instead of `lastUpdatedAfter` * OAuthFlows * `deviceCode` has been added, `implicit` & `password` have been removed * AuthorizationCodeOAuthFlow * new `pkce_required` boolean field Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
…dAgentCardXXX Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
475cdb2 to
5770009
Compare
|
/gemini summary |
Summary of ChangesThis pull request incorporates significant updates to the core Highlights
Changelog
Activity
|
based on commit a2aproject/A2A@0572953
spec-grpc module has been regenerated from the updated a2a.proto
Key changes:
supportsExtendedAgentCardfield)protocolVersion)msgfield is now namedmessagelastUpdatedAfterdeviceCodehas been added,implicit&passwordhave been removedpkce_requiredboolean field