Rename 'Grammar' optional step group to 'Antlr' in deploy_to_develop …#2060
Open
gyanranjanpanda wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Conversation
…pipeline Fixes aboutcode-org#2057 The decorator was used for three pipeline steps that handle ANTLR-specific grammar files (.g/.g4). The name "Grammar" is too generic and ambiguous — it does not make clear which grammar tool or technology is involved. Rename the optional step group from "Grammar" to "Antlr" to: - Align with all other optional step groups in the pipeline that are named after their specific technology (Java, Scala, Kotlin, Groovy, AspectJ, Clojure, etc.) - Make the user-facing CLI --groups flag, REST API, and UI unambiguous - Clearly communicate that these steps are exclusively for ANTLR grammar files The three affected steps are: - find_grammar_packages: finds java packages in .g/.g4 source files - map_grammar_to_class: maps .class files to their .g/.g4 source - map_jar_to_grammar_source: maps .jar files to their ANTLR source directory Note: Internal class names (GrammarLanguage, grammar_package, grammar_to_class) are database-persisted identifiers and are intentionally NOT changed to avoid requiring a data migration. Backward compatibility note: Existing pipeline configs or API calls using "--groups Grammar" must be updated to "--groups Antlr" after this change. Signed-off-by: Gyan Ranjan Panda <gyanranjanpanda@gmail.com>
gyanranjanpanda
force-pushed
the
fix/rename-grammar-to-antlr-optional-step-2057
branch
from
8672a72 to
5993935
Compare
Author
|
hi @pombredanne could u review this waiting for your feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2057
Rename the optional step group from "Grammar" to "Antlr" in the
develop_to_deploypipeline to remove ambiguity and align with other technology-specific group names.This affects three ANTLR-related steps handling
.g/.g4files:find_grammar_packagesmap_grammar_to_classmap_jar_to_grammar_sourceInternal identifiers (e.g.,
GrammarLanguage, database keys) are intentionally unchanged to avoid migrations.Note: Existing configs or API calls using
--groups Grammarmust be updated to--groups Antlr.