Skip to content

feat: add support for Devanagari & Bengali decimal numbering systems#6715

Merged
LFDanLu merged 6 commits intomainfrom
rocss/extended-ime-support
Nov 12, 2024
Merged

feat: add support for Devanagari & Bengali decimal numbering systems#6715
LFDanLu merged 6 commits intomainfrom
rocss/extended-ime-support

Conversation

@Rocss
Copy link
Contributor

@Rocss Rocss commented Jul 16, 2024

Closes #6623

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Adobe Express

@rspbot
Copy link

rspbot commented Jul 16, 2024

Build successful! 🎉

@Rocss
Copy link
Contributor Author

Rocss commented Jul 16, 2024

Currently this is being tested by Express g18n team. Will come back with updating all the necessary documentation when it is validated.

@devongovett devongovett force-pushed the main branch 2 times, most recently from 8cb1a5d to 3013156 Compare July 23, 2024 22:43
@devongovett devongovett force-pushed the main branch 2 times, most recently from a79adcf to 3013156 Compare September 30, 2024 21:00
@rspbot
Copy link

rspbot commented Oct 29, 2024

Build successful! 🎉

@Rocss Rocss marked this pull request as ready for review October 30, 2024 10:09
@Rocss
Copy link
Contributor Author

Rocss commented Oct 30, 2024

I am marking this as ready for review as it was finally tested by Express g18n team and confirmed that number field works well for Hindi and Bengali keyboards.
Happy to address any other code review, I don't know what I missed 😅

@majornista I think this PR is affecting your PR: #6520, would you like me to add additional checks to mine?

@Rocss Rocss requested a review from snowystinger November 6, 2024 12:59
snowystinger
snowystinger reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, thanks for the tests.

@Rocss @snowystinger
Update packages/react-aria-components/docs/NumberField.mdx
8f9d933 
Co-authored-by: Robert Snow <rsnow@adobe.com>
@rspbot
Copy link

rspbot commented Nov 7, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented Nov 7, 2024

Build successful! 🎉

@Rocss
Copy link
Contributor Author

Rocss commented Nov 11, 2024

I no longer have the option to add additional reviewers, @snowystinger would you help me ping additional RS members for code review?

@snowystinger
Copy link
Member

snowystinger commented Nov 11, 2024

Someone else on the team will review it, thank you for your patience

LFDanLu
LFDanLu approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified I was able to type various numeric values via IDE into the NumberField when Devanagari and Bengali was enabled

@LFDanLu LFDanLu enabled auto-merge November 12, 2024 01:31
@rspbot
Copy link

rspbot commented Nov 12, 2024

Build successful! 🎉

@LFDanLu LFDanLu added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit f08b17d Nov 12, 2024
@LFDanLu LFDanLu deleted the rocss/extended-ime-support branch November 12, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rocss @rspbot @snowystinger @LFDanLu

Comments