fix: Prevent Spectrum Picker from selecting new value after closing#8475
fix: Prevent Spectrum Picker from selecting new value after closing#8475snowystinger wants to merge 3 commits intomainfrom
Conversation
|
Build successful! 🎉 |
There was a problem hiding this comment.
I can still reproduce the issue here: https://reactspectrum.blob.core.windows.net/reactspectrum/24d476a0a7dfb2e6c6a7efdbddcb387f35359ac9/storybook/index.html?path=/story/picker--default&providerSwitcher-express=false
on Chrome Mac.
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
reproduces in safari as well |
|
Yeah, I haven't figured out what's wrong yet |
snowystinger
left a comment
There was a problem hiding this comment.
Quick summary, I was correct that the selection is happening as the popover is animating out. This can be seen by setting the animation speed to 10% of normal making it easier to reproduce. The issue is that the ListBox items are getting pointerEvents auto thanks to the user style sheet.
We can override it on all children. But this doesn't feel like a great long term solution and is hard to change in RAC/S2.
We can't apply inert to the Popover because then we lose focus before we're ready for that.
|
Build successful! 🎉 |
d5d23c6 to
53e94bc
Compare
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Closes #7537
✅ Pull Request Checklist:
📝 Test Instructions:
Go to V3 storybook or v3 docs for Picker. Select an option with your mouse, then, as the popover is closing, quickly click where another item used to be.
🧢 Your Project: