fix(s2-docs): auto-scroll and expand section for group selected nav link#9664
Open
domhhv wants to merge 1 commit intoadobe:mainfrom
Open
fix(s2-docs): auto-scroll and expand section for group selected nav link#9664domhhv wants to merge 1 commit intoadobe:mainfrom
domhhv wants to merge 1 commit intoadobe:mainfrom
Conversation
Member
snowystinger
left a comment
There was a problem hiding this comment.
Thanks for the PR, just a minor note
| return; | ||
| } | ||
|
|
||
| linkRef.current.scrollIntoView({block: 'start', behavior: 'smooth'}); |
Member
There was a problem hiding this comment.
I think we'll want to use our scrollIntoViewport from @react-aria/utils
This way it'll only scroll into view if it's currently out of view and it'll fix some issues across browsers.
Member
|
You'll also need to sign the CLA https://github.com/adobe/react-spectrum/blob/main/CONTRIBUTING.md#contributor-license-agreement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9663
✅ Pull Request Checklist:
📝 Test Instructions:
Current behaviour (prod):
Screen.Recording.2026-02-15.at.19.36.53.mov
Ideal behaviour (this changeset):
Screen.Recording.2026-02-15.at.19.38.06.mov
Summary of changes needed for this in
packages/dev/s2-docs/src/Nav.tsx:🧢 Your Project:
https://github.com/domhhv/habitrack