Skip to content

Conversation

@anna239
Copy link
Contributor

@anna239 anna239 commented Feb 2, 2026

No description provided.

@anna239 anna239 requested a review from a team as a code owner February 2, 2026 13:41
Copy link

@yordis yordis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My primary concern are,

Boolean explosion

If we add deleted, Would we add created, renamed, etc? Are we comfortable turning diff into a growing bag of flags with unclear combinations?

Explicit operation

Isn’t deleted an operation (the file’s post-state) rather than an attribute? Wouldn’t a single kind: added|modified|deleted be the more direct representation and closer to how tools like git model it?

Semantic complexity

What does deleted=true actually mean for newText and validation rules? Must newText be empty, ignored, or still applied? How do we prevent contradictory payloads like deleted=true with non-empty newText, or deleted=false with /dev/null-style semantics later?

Copy link
Member

@benbrandt benbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anna239 let's turn this into the long-awaited new version of diff that supports more info so we can represent stuff like add/delete/move/edit and maybe include stuff like line numbers etc

@ignatov
Copy link
Contributor

ignatov commented Feb 4, 2026

I think that deleted here is only for the sake of compatibility, as we don't want to have a breaking change for a tiny fix

@ignatov
Copy link
Contributor

ignatov commented Feb 4, 2026

@anna239 let's turn this into the long-awaited new version of diff that supports more info so we can represent stuff like add/delete/move/edit and maybe include stuff like line numbers etc

@benbrandt I suppose the can do a tiny non-breaking change and after do some real fixes in the product, after we can start a new wave of discussions towards our shiny feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants