-
Notifications
You must be signed in to change notification settings - Fork 144
Added file-delete.mdx #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
yordis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My primary concern are,
Boolean explosion
If we add deleted, Would we add created, renamed, etc? Are we comfortable turning diff into a growing bag of flags with unclear combinations?
Explicit operation
Isn’t deleted an operation (the file’s post-state) rather than an attribute? Wouldn’t a single kind: added|modified|deleted be the more direct representation and closer to how tools like git model it?
Semantic complexity
What does deleted=true actually mean for newText and validation rules? Must newText be empty, ignored, or still applied? How do we prevent contradictory payloads like deleted=true with non-empty newText, or deleted=false with /dev/null-style semantics later?
benbrandt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anna239 let's turn this into the long-awaited new version of diff that supports more info so we can represent stuff like add/delete/move/edit and maybe include stuff like line numbers etc
|
I think that deleted here is only for the sake of compatibility, as we don't want to have a breaking change for a tiny fix |
@benbrandt I suppose the can do a tiny non-breaking change and after do some real fixes in the product, after we can start a new wave of discussions towards our shiny feature |
No description provided.