fix: callback inappropriately suppresses asyncio logs #725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes something I broke in my previous PR.
What do these changes do?
We must use the private
_exceptionattribute instead ofexception()so asyncio does not settask.__log_traceback = Falseon the false assumption that the caller read the task ExceptionAre there changes in behavior for the user?
The suppressed logs from asyncio will no longer be suppressed and behavior will work as expected in a normal asyncio application
Related issue number
N/A
Checklist