Skip to content

Conversation

@asvetlov
Copy link
Member

What do these changes do?

yarl.URL could be used in pydantic models without a boilrplate.

Are there changes in behavior for the user?

The change doesn't break any existing code but helps with URL serialization/deserialization of pydantic models if the library was installed by user.

Related issue number

None

Checklist

  • [x ] I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 12, 2025

CodSpeed Performance Report

Merging #1607 will degrade performances by 25.46%

Comparing asvetlov:pydantic (941eb6d) with master (383b159)

Summary

❌ 1 (👁 1) regression
✅ 98 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_quote_query_string 74.2 µs 99.5 µs -25.46%

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 80.95238% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.37%. Comparing base (383b159) to head (941eb6d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
yarl/_url.py 45.45% 1 Missing and 11 partials ⚠️

❌ Your project status has failed because the head coverage (97.63%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1607      +/-   ##
==========================================
- Coverage   99.57%   99.37%   -0.20%     
==========================================
  Files          29       30       +1     
  Lines        5877     5940      +63     
  Branches      266      282      +16     
==========================================
+ Hits         5852     5903      +51     
- Misses         21       22       +1     
- Partials        4       15      +11     
Flag Coverage Δ
CI-GHA 99.37% <80.95%> (-0.20%) ⬇️
MyPy 97.63% <67.74%> (-0.32%) ⬇️
OS-Linux 99.73% <97.61%> (-0.08%) ⬇️
OS-Windows 98.66% <19.04%> (-0.83%) ⬇️
OS-macOS 98.80% <19.04%> (-0.88%) ⬇️
Py-3.10.11 98.63% <19.04%> (-0.83%) ⬇️
Py-3.10.19 99.65% <95.23%> (-0.05%) ⬇️
Py-3.11.14 99.65% <95.23%> (-0.05%) ⬇️
Py-3.11.9 98.63% <19.04%> (-0.83%) ⬇️
Py-3.12.10 98.63% <19.04%> (-0.83%) ⬇️
Py-3.12.12 99.65% <95.23%> (-0.05%) ⬇️
Py-3.13.11 99.70% <100.00%> (-0.05%) ⬇️
Py-3.13.11t 99.70% <100.00%> (-0.05%) ⬇️
Py-3.14.2 99.70% <100.00%> (-0.05%) ⬇️
Py-3.14.2t 99.70% <100.00%> (-0.05%) ⬇️
Py-pypy3.10.16-7.3.19 99.31% <95.23%> (-0.05%) ⬇️
VM-macos-latest 98.80% <19.04%> (-0.88%) ⬇️
VM-ubuntu-latest 99.73% <97.61%> (-0.08%) ⬇️
VM-windows-latest 98.66% <19.04%> (-0.83%) ⬇️
pytest 99.75% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 12, 2025
@asvetlov asvetlov marked this pull request as ready for review December 12, 2025 11:31
@asvetlov asvetlov requested a review from bdraco December 12, 2025 11:31
@bdraco
Copy link
Member

bdraco commented Dec 12, 2025

LGTM.

I'll look at fixing the CI later today

@bdraco
Copy link
Member

bdraco commented Dec 12, 2025

CI is fixed. The failures are legitimate build issues with this PR now.

@bdraco
Copy link
Member

bdraco commented Dec 15, 2025

the macos / windows 3.13t tests are failing because of the 5m timeout and there are no pydantic wheels for those archs so it has to build them

@asvetlov
Copy link
Member Author

Let's run pydantic tests for Linux only on CI, it should be enough

@asvetlov asvetlov merged commit f307123 into aio-libs:master Dec 16, 2025
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants