-
-
Notifications
You must be signed in to change notification settings - Fork 176
Add pydantic support #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pydantic support #1607
Conversation
CodSpeed Performance ReportMerging #1607 will degrade performances by 25.46%Comparing Summary
Benchmarks breakdown
|
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (97.63%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
- Coverage 99.57% 99.37% -0.20%
==========================================
Files 29 30 +1
Lines 5877 5940 +63
Branches 266 282 +16
==========================================
+ Hits 5852 5903 +51
- Misses 21 22 +1
- Partials 4 15 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM. I'll look at fixing the CI later today |
|
CI is fixed. The failures are legitimate build issues with this PR now. |
|
the macos / windows 3.13t tests are failing because of the 5m timeout and there are no pydantic wheels for those archs so it has to build them |
|
Let's run pydantic tests for Linux only on CI, it should be enough |
What do these changes do?
yarl.URLcould be used inpydanticmodels without a boilrplate.Are there changes in behavior for the user?
The change doesn't break any existing code but helps with URL serialization/deserialization of
pydanticmodels if the library was installed by user.Related issue number
None
Checklist