Update README file - Extend explanations, fix formatting mistakes and expand examples#2938
Open
bstashchuk wants to merge 13 commits intoairbnb:masterfrom
Open
Update README file - Extend explanations, fix formatting mistakes and expand examples#2938bstashchuk wants to merge 13 commits intoairbnb:masterfrom
bstashchuk wants to merge 13 commits intoairbnb:masterfrom
Conversation
bstashchuk
commented
Mar 7, 2024
bstashchuk
commented
Mar 7, 2024
bstashchuk
commented
Mar 7, 2024
bstashchuk
commented
Mar 7, 2024
ljharb
requested changes
Mar 7, 2024
bstashchuk
commented
Mar 7, 2024
Author
bstashchuk
left a comment
bstashchuk
left a comment
There was a problem hiding this comment.
Thanks for the quick feedback @ljharb
I hope we will be able to incorporate few of my changes.
ljharb
reviewed
Mar 8, 2024
Author
|
@ljharb I am still thinking about 19.6 There are actually general ESLint rules regarding method chains formatting but for some reason all examples are about jQuery and DOM manipulation. No pure JS examples of methods chaining for arrays or some objects manipulation. May I reduce quantity of the jQuery examples (or make them less confusing due to the long chains of method calls with different indents) and add some additional examples with bad/good formatting? |
ljharb
reviewed
Mar 10, 2024
ljharb
reviewed
Mar 10, 2024
bstashchuk
commented
Mar 10, 2024
bstashchuk
force-pushed
the
update-readme
branch
from
bed075e to
352c3db
Compare
Author
|
Hi @ljharb , |
bstashchuk
force-pushed
the
update-readme
branch
2 times, most recently
from
352c3db to
891cff2
Compare
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
bstashchuk
force-pushed
the
update-readme
branch
from
891cff2 to
396251f
Compare
anandfresh
approved these changes
Sep 29, 2024
ljharb
requested changes
Sep 30, 2024
ljharb
reviewed
Dec 12, 2024
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am author of few JavaScript courses on Udemy.
While recording new JavaScript course I used AirBnb Style Guide in one of the sections and noticed few ways for improvements.