Support flat config for eslint-config-airbnb-base#3061
Support flat config for eslint-config-airbnb-base#3061tamiroh wants to merge 2 commits intoairbnb:masterfrom
eslint-config-airbnb-base#3061Conversation
eslint-config-airbnb-base
c13cacf to
b546a7e
Compare
|
Is this pull request fully functional? only approval is missing? |
|
@mcorbelli no, it’s not functional until eslint-find-rules is updated. |
|
@ljharb FYI: eslint-find-rules does have flat-config support now: https://github.com/sarbbottam/eslint-find-rules/releases/tag/v4.2.0 |
|
Thanks, I’m aware since I’m the one who published it :-) |
| "node": "^10.12.0 || >=12.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "confusing-browser-globals": "^1.0.11" |
There was a problem hiding this comment.
The goal of this PR is to ensure compatibility between eslint-config-airbnb-base and ESLint 9, correct? It looks like you'll need to update line 83 to include ESLint 9 as a peer dependency.
There was a problem hiding this comment.
Thank you for pointing this out. And sorry for the delay 🥲.
Fixed in 1009adc.
|
Any update on when we're planning to get this in? |
|
@ljharb |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@tamiroh, Looks like there's some rebasing issues. |
|
@ljharb Can we prioritize this ? And get this merged. Thanks. |
|
I added a PR that is this rebased from master: #3123 |
|
Please don't do that. I can rebase this PR any time I like; rebasing isn't what's delaying this PR, my availability is. |
|
@ljharb I've been following and I know about your commitments, tasks and responsibilities with the community, but do you have any idea when support for version 9 will be available? I'm just asking because we really need support for version 9. There are many libs that depend on Airbnb. |
|
Hi @ljharb, I hope you're doing well. Can we still hope that when you have some time, you'll help with compatibility with v9? |
This pull request supports flat config for
eslint-config-airbnb-base.An example of usage is as follows.