Fix retry storm problem in data fetching in visualizer #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests - Introduced a flag to track ongoing fetch requests, preventing multiple simultaneous calls to the API. - The problem of retry storm can happen if the data is large or the bandwidth is limited. fetchAndRender does not finish before the next interval and a buildup of requests will happen.
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the visualizer/main.js where multiple simultaneous data-fetching requests could be triggered if a previous request had not yet completed.
In scenarios with high latency, limited bandwidth, or large data payloads, the
fetchAndRenderfunction could overlap with the next scheduled interval. This led to a "retry storm" or request buildup, unnecessarily taxing the API causing UI to not be able to load the data or crash after some time.