feat: adds region tags to ListDetailSample.kt

[telpirion]

The samples in this repo don't currently have region tags.

The pull request does the following:

• Adds the following region tag: android_adaptive_list_detail_pane_scaffold_compose_full.
• Migrates the list-detail-compose sample to use the NavigableListDetailPaneScaffold.

[gemini-code-assist]

Summary of Changes

Hello @telpirion, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the ListDetailSample.kt by integrating a new region tag for better documentation and discoverability. It also modernizes the underlying architecture by migrating to the NavigableListDetailPaneScaffold from the Material3 Adaptive library, which streamlines navigation and state persistence for list-detail UIs. These changes improve the sample's adherence to best practices and its utility for developers.

Highlights

• Region Tag Addition: A new region tag, android_adaptive_list_detail_pane_scaffold_compose_full, has been added to ListDetailSample.kt to improve code sample discoverability and documentation.
• Dependency Updates: The build.gradle file has been updated to include the kotlin-parcelize plugin and the androidx.compose.material:material-icons-extended dependency, enabling new functionalities.
• Refactoring to NavigableListDetailPaneScaffold: The ListDetailSample.kt file has been refactored to utilize the NavigableListDetailPaneScaffold from the Material3 Adaptive library, enhancing navigation and state management within the list-detail UI pattern.
• Data Class Parcelable Implementation: The DefinedWord data class now implements Parcelable using the kotlin-parcelize plugin, allowing for efficient data transfer between components.
• UI Component Modernization: The ListContent and DetailContent composables have been updated to align with the new navigation pattern, including changes to how selected items are handled and the introduction of a close button for the detail pane.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the ListDetailSample to use the NavigableListDetailPaneScaffold, which greatly simplifies the state management and navigation logic. The code is now cleaner and easier to understand. The addition of the region tag is also correctly implemented. I've added a few suggestions to further improve code readability and adhere to best practices for accessibility.

[gemini-code-assist]

The itemsIndexed lambda provides the word object directly. You can use it here instead of accessing it from the words list by index (words[index]). This improves readability and avoids an unnecessary list lookup.

Suggested change

	val interactionModifier = when (selectionState) {
	SelectionVisibilityState.NoSelection -> {
	Modifier.clickable(
	onClick = { onIndexClick(index) }
	onClick = { onWordClick(words[index]) }
	)
	}
	is SelectionVisibilityState.ShowSelection -> {
	Modifier.selectable(
	selected = index == selectionState.selectedWordIndex,
	onClick = { onIndexClick(index) }
	selected = words[index] == selectionState.selectedWord,
	onClick = { onWordClick(words[index]) }
	)
	}
	}
	val interactionModifier = when (selectionState) {
	SelectionVisibilityState.NoSelection -> {
	Modifier.clickable(
	onClick = { onWordClick(word) }
	)
	}
	is SelectionVisibilityState.ShowSelection -> {
	Modifier.selectable(
	selected = word == selectionState.selectedWord,
	onClick = { onWordClick(word) }
	)
	}
	}

[gemini-code-assist]

For better accessibility and to support internationalization, it's recommended to use string resources for UI text. Please extract "Close" to a string resource in strings.xml (e.g., <string name="close">Close</string>) and reference it here using stringResource().

Suggested change

	Icon(Icons.Default.Close, contentDescription = "Close")
	Icon(Icons.Default.Close, contentDescription = stringResource(R.string.close))