Skip to content

perf(@angular/cli): cache resolved specific version in package manager abstraction #32099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Dec 11, 2025
+13 −2
Merged

perf(@angular/cli): cache resolved specific version in package manager abstraction #32099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/angular/cli/src/package-managers/package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import { join } from 'node:path';
import npa from 'npm-package-arg';
import { maxSatisfying } from 'semver';
import { ErrorInfo, PackageManagerError } from './error';
import { PackageManagerError } from './error';
import { Host } from './host';
import { Logger } from './logger';
import { PackageManagerDescriptor } from './package-manager-descriptor';
Expand Down Expand Up @@ -407,11 +407,22 @@ export class PackageManager {

const cacheKey = options.registry ? `${specifier}|${options.registry}` : specifier;

return this.#fetchAndParse(
const manifest = await this.#fetchAndParse(
commandArgs,
(stdout, logger) => this.descriptor.outputParsers.getRegistryManifest(stdout, logger),
{ ...options, cache: this.#manifestCache, cacheKey },
);

// If the provided version was not a specific version, also cache the specific fetched version
if (manifest && manifest.version !== version) {
const manifestSpecifier = `${manifest.name}@${manifest.version}`;
const manifestCacheKey = options.registry
? `${manifestSpecifier}|${options.registry}`
: manifestSpecifier;
this.#manifestCache.set(manifestCacheKey, manifest);
}

return manifest;
}

/**
Expand Down