Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 2, 2026

Some Aria directives were using outputs prefixed with on which is explicitly called out as a anti-pattern in the styleguide (see https://angular.dev/guide/components/outputs#choosing-event-names).

Fixes #32727.

Removes the `on` prefixs from outputs in the grid to align it with the styleguide.

Fixes angular#32727.
Removes the `on` prefixs from outputs in the menu to align it with the styleguide.

Fixes angular#32727.
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release merge: preserve commits When the PR is merged, a rebase and merge should be performed labels Feb 2, 2026
@pullapprove pullapprove bot requested review from mmalerba and tjshiu February 2, 2026 13:08
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 2, 2026
@crisbeto crisbeto merged commit d030725 into angular:main Feb 2, 2026
29 of 31 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Feb 2, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker merge: preserve commits When the PR is merged, a rebase and merge should be performed target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs-bug(Menu): Aria Menu has an output prefixed with "on", discouraged elsewhere

3 participants