perf: optimize model dialog visibility lookups #6791
Merged
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visible() function was called in a filter loop for each model, performing O(n) lookups on both store.user and latest() arrays. This caused noticeable lag in the model dialog during longer sessions. Replace linear array searches with memoized Set and Map structures: - latestSet: O(1) lookup for whether a model is in the latest set - userVisibilityMap: O(1) lookup for user visibility preferences This reduces the overall complexity from O(n²) to O(n) when filtering the model list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
visible()functionProblem
The
visible()function inpackages/app/src/context/local.tsxwas called inside a.filter()loop for each model. Each call performed:store.userarraylatest()array (which involves expensive date computations)With many models, this became O(n²) and caused noticeable lag when opening the model selector.
Solution
Added two memoized lookup structures:
latestSet: ASetfor O(1) lookup of whether a model is "latest"userVisibilityMap: AMapfor O(1) lookup of user visibility preferencesThe memos are only recomputed when their underlying data changes, not on every
visible()call.