fix(lsp): add shell option for Dart LSP on Windows #6863
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, Bun.which('dart') may resolve to a .cmd shim or
the spawn call may fail without shell: true. This adds the
shell option specifically for Windows to fix the 'Command not
found: dart' error.
Fixes anomalyco#6861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Dart LSP failing on Windows with "Command not found: dart" error by adding
shell: trueto the spawn options when running on Windows.Problem
On Windows, the Dart LSP server fails to start even when
dartis correctly installed and in PATH. The error occurs because:Bun.which("dart")finds a valid path (e.g.,C:\Users\...\bin\dart.exe)spawn()withoutshell: truecan fail on Windows for certain executable configurationsSolution
Add
shell: process.platform === "win32"to the spawn options, following the same pattern used elsewhere in the codebase (e.g.,npm.cmdhandling in ESLint LSP).Testing
dart language-server --lspworks via shellFixes #6861
cc @thdxr @adamdotdevin